notionflux: Allow passing a filename, which is sent as dofile() stmt #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some manpage stuff.
raboof
approved these changes
Jun 21, 2019
| @@ -92,6 +115,8 @@ The document | |||
| .Dq Configuring and extending Notion with Lua | |||
| found on the Notion homepage. | |||
| .Pp | |||
| .Lk https://www.lua.org/manual/LUA_REFVERSION/manual.html "The Lua LUA_REFVERSION reference manual" | |||
| } | ||
|
|
||
| if (!buf_append(buf, "');--")) | ||
| die("Filename too long.\n"); |
There was a problem hiding this comment.
You never know, the filename could be 1024 bytes of non-printable \127 characters :)
|
Build on C89 failed but I think we agree on moving on to C99, once we fix the build LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for passing long files which don't fit into mod_notionflux's buffer.
Also some more manpage stuff.