Change query_runfile (View) to use xdg-open by default #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Edit/View file can be customized by setting EDIT_COMMAND/VIEW_COMMAND in etc/cfg_notion.lua Fix #144
wilhelmy
reviewed
Oct 10, 2019
| -- alternative script to use. The default prompt is "View file:" (translated). | ||
| function mod_query.query_runfile(mplex, script, prompt) | ||
| mod_query.query_execfile(mplex, | ||
| prompt or TR("View file:"), | ||
| script or "run-mailcap --action=view") | ||
| script or "xdg-open") |
There was a problem hiding this comment.
… and if VIEW_COMMAND is global, it can theoretically be used here. Not sure that's clean design, though, and whether or not it should be global. Any opinions?
There was a problem hiding this comment.
I thought about it but I saw mod_dock as a separate module and didn't want to "trust" that those variables are defined. Let me know if you think these should point to those vars.
There was a problem hiding this comment.
If we decide to go with the "cmds" approach mentioned above, I think (cmds and cmds.VIEW) or "xdg-open" should work around the value being nil
raboof
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Edit/View file can be customized by setting EDIT_COMMAND/VIEW_COMMAND
in etc/cfg_notion.lua
Fix #144