Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing user facing verbiage of vertical horizontal to rows and columns #294

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions etc/cfg_notion3_tiling.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

-- Bindings for the tilings.
defbindings("WTiling", {
bdoc("Split current frame vertically."),
bdoc("Split current into rows."),
kpress(META.."S", "WTiling.split_at(_, _sub, 'bottom', true)"),

bdoc("Go to frame above/below current frame."),
Expand All @@ -18,7 +18,7 @@ defbindings("WTiling", {
submap(META.."K", {
kpress("Tab", "ioncore.goto_next(_sub, 'left')"),

bdoc("Split current frame horizontally."),
bdoc("Split current into columns."),
kpress("S", "WTiling.split_at(_, _sub, 'right', true)"),

bdoc("Destroy current frame."),
Expand All @@ -39,9 +39,9 @@ defctxmenu("WTiling", "Tiling", {
menuentry("Destroy frame",
"WTiling.unsplit_at(_, _sub)"),

menuentry("Split vertically",
menuentry("Into rows",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps 'Split into rows' would be even clearer, but 👍

"WTiling.split_at(_, _sub, 'bottom', true)"),
menuentry("Split horizontally",
menuentry("Into columns",
"WTiling.split_at(_, _sub, 'right', true)"),

menuentry("Flip", "WTiling.flip_at(_, _sub)"),
Expand All @@ -61,9 +61,9 @@ defctxmenu("WTiling", "Tiling", {
}),

submenu("At root", {
menuentry("Split vertically",
menuentry("Into rows",
"WTiling.split_top(_, 'bottom')"),
menuentry("Split horizontally",
menuentry("Into columns",
"WTiling.split_top(_, 'right')"),
menuentry("Flip", "WTiling.flip_at(_)"),
menuentry("Transpose", "WTiling.transpose_at(_)"),
Expand Down
12 changes: 6 additions & 6 deletions etc/cfg_tiling.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

-- Bindings for the tilings.
defbindings("WTiling", {
bdoc("Split current frame horizontally.", "hsplit"),
bdoc("Split current into columns.", "hsplit"),
kpress(META.."I", "WTiling.split_at(_, _sub, 'right', true)"),

bdoc("Split current frame vertically.", "vsplit"),
bdoc("Split current into rows.", "vsplit"),
kpress(ALTMETA.."I", "WTiling.split_at(_, _sub, 'bottom', true)"),

bdoc("Destroy current frame.", "unsplit"),
Expand All @@ -32,9 +32,9 @@ defctxmenu("WTiling", "Tiling", {
menuentry("Destroy frame",
"WTiling.unsplit_at(_, _sub)"),

menuentry("Split vertically",
menuentry("Into rows",
"WTiling.split_at(_, _sub, 'bottom', true)"),
menuentry("Split horizontally",
menuentry("Into columns",
"WTiling.split_at(_, _sub, 'right', true)"),

menuentry("Flip", "WTiling.flip_at(_, _sub)"),
Expand All @@ -54,9 +54,9 @@ defctxmenu("WTiling", "Tiling", {
}),

submenu("At root", {
menuentry("Split vertically",
menuentry("Into Rows",
"WTiling.split_top(_, 'bottom')"),
menuentry("Split horizontally",
menuentry("Into columns",
"WTiling.split_top(_, 'right')"),
menuentry("Flip", "WTiling.flip_at(_)"),
menuentry("Transpose", "WTiling.transpose_at(_)"),
Expand Down