feat: [ACI-850] implement badge completion check #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wowkalucky
requested changes
Apr 8, 2024
wowkalucky
requested changes
Apr 8, 2024
credentials/apps/badges/models.py
Outdated
| return self.user_progress(username) == 1.0 | ||
|
|
||
| @property | ||
| def ratio(self) -> float: |
There was a problem hiding this comment.
This property is expected to be on the BadgeProgress, so it is possible to get the exact badge template progress value on a specific BadgeProgress record (not a generic ratio on a BadgeTemplate).
So, the .ratio value must mirror the .user_progress(username) but from the progress instance side.
There was a problem hiding this comment.
Sorry, if this wasn't that clear in the description 😞
wowkalucky
requested changes
Apr 8, 2024
wowkalucky
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.