-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [ACI-980] allow pre configured credly organizations #173
feat: [ACI-980] allow pre configured credly organizations #173
Conversation
credentials/apps/badges/admin.py
Outdated
if not obj: | ||
return readonly_fields | ||
|
||
if str(obj.uuid) in settings.BADGES_CONFIG["credly"].get("ORGANIZATIONS", {}).keys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repetitive >> get_preconfigured_organozations()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extracted
@@ -40,7 +40,7 @@ class CredlyOrganization(TimeStampedModel): | |||
""" | |||
|
|||
uuid = models.UUIDField(unique=True, help_text=_("Put your Credly Organization ID here.")) | |||
api_key = models.CharField(max_length=255, help_text=_("Credly API shared secret for Credly Organization.")) | |||
api_key = models.CharField(max_length=255, help_text=_("Credly API shared secret for Credly Organization."), blank=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
849b516
to
fa8e52e
Compare
fa8e52e
to
4c524f2
Compare
No description provided.