Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ACI-980] allow pre configured credly organizations #173

Merged

Conversation

andrii-hantkovskyi
Copy link

No description provided.

if not obj:
return readonly_fields

if str(obj.uuid) in settings.BADGES_CONFIG["credly"].get("ORGANIZATIONS", {}).keys():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repetitive >> get_preconfigured_organozations()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted

@@ -40,7 +40,7 @@ class CredlyOrganization(TimeStampedModel):
"""

uuid = models.UUIDField(unique=True, help_text=_("Put your Credly Organization ID here."))
api_key = models.CharField(max_length=255, help_text=_("Credly API shared secret for Credly Organization."))
api_key = models.CharField(max_length=255, help_text=_("Credly API shared secret for Credly Organization."), blank=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB migration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@andrii-hantkovskyi andrii-hantkovskyi force-pushed the hantkovskyi/aci-980/preconfigured-credly-organizations branch from 849b516 to fa8e52e Compare May 17, 2024 17:40
@andrii-hantkovskyi andrii-hantkovskyi force-pushed the hantkovskyi/aci-980/preconfigured-credly-organizations branch from fa8e52e to 4c524f2 Compare May 17, 2024 17:41
@andrii-hantkovskyi andrii-hantkovskyi marked this pull request as ready for review May 17, 2024 18:10
@wowkalucky wowkalucky merged commit ece7c9a into aci.main May 20, 2024
1 of 2 checks passed
@wowkalucky wowkalucky deleted the hantkovskyi/aci-980/preconfigured-credly-organizations branch May 20, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants