Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ACI-461] define CredlyBadge credential model #80

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

andrii-hantkovskyi
Copy link

No description provided.

@andrii-hantkovskyi andrii-hantkovskyi marked this pull request as ready for review March 26, 2024 12:25
ISSUING_STATES = Choices("created", "no_response", "error", "pending", "accepted", "rejected", "revoked")

issuing_state = StatusField(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename to state since it will be related for different pipelines: issuing, revocation, etc.

...and I'm expecting data migration here for the new field?


ISSUING_STATES = Choices("created", "no_response", "error", "pending", "accepted", "rejected", "revoked")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same >> just STATES

@wowkalucky wowkalucky removed the to do label Mar 28, 2024
@wowkalucky wowkalucky merged commit 279ed81 into aci.main Mar 28, 2024
2 checks passed
@wowkalucky wowkalucky deleted the hantkovskyi/aci-461/credly-badge-model branch March 28, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants