Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rustc-ap crates to v677 #1129

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

calebcartwright
Copy link
Contributor

We need to bump the rustc-ap crates again to fix the broken toolstates for rustfmt and rls on nightly.

AFAICT the 5 failing tests are existing/unrelated, and reproducible on master

rust-lang/rust#76146
rust-lang/rust#76145

@Xanewok
Copy link
Collaborator

Xanewok commented Sep 3, 2020

FWIW this doesn't seem to regress anything, assuming my #1130 actually works and doesn't green-light every test 😅

As such, I think it'd be great to land this asap due to broken toolstate.

@calebcartwright would you mind also updating rust-toolchain here to e.g. 2020-09-02? It seems the CI is failing since we're using too old of a nightly toolchain.

@Xanewok Xanewok merged commit 2bda0ad into racer-rust:master Sep 4, 2020
@Xanewok
Copy link
Collaborator

Xanewok commented Sep 4, 2020

Thanks!

@calebcartwright calebcartwright deleted the rustc-ap-bump branch September 4, 2020 14:02
@Xanewok
Copy link
Collaborator

Xanewok commented Sep 4, 2020

Published a new version: https://crates.io/crates/racer/2.1.38

@kngwyu fyi

@kngwyu
Copy link
Collaborator

kngwyu commented Sep 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants