Fixed Mutator Flyout Being Positioned Incorrectly RTL (google#2378)

* Fixed mutator flyout being positioned incorrectly. * Changed flyout_horizonal and flyout_vertical to check this.targetWorkspace_.toolboxPosition instead of targetWorkspaceMetrics.toolboxPosition.
rachel-fenichel · Apr 15, 2019 · 5fe2bc6 · 5fe2bc6
1 parent dbda2ea
commit 5fe2bc6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/flyout_horizontal.js b/core/flyout_horizontal.js
@@ -155,7 +155,7 @@ Blockly.HorizontalFlyout.prototype.position = function() {
   // X is always 0 since this is a horizontal flyout.
   var x = 0;
   // If this flyout is the toolbox flyout.
-  if (targetWorkspaceMetrics.toolboxPosition == this.toolboxPosition_) {
+  if (this.targetWorkspace_.toolboxPosition == this.toolboxPosition_) {
     // If there is a toolbox.
     if (targetWorkspaceMetrics.toolboxHeight) {
       if (this.toolboxPosition_ == Blockly.TOOLBOX_AT_TOP) {

diff --git a/core/flyout_vertical.js b/core/flyout_vertical.js
@@ -152,7 +152,7 @@ Blockly.VerticalFlyout.prototype.position = function() {
   // Y is always 0 since this is a vertical flyout.
   var y = 0;
   // If this flyout is the toolbox flyout.
-  if (targetWorkspaceMetrics.toolboxPosition == this.toolboxPosition_) {
+  if (this.targetWorkspace_.toolboxPosition == this.toolboxPosition_) {
     // If there is a category toolbox.
     if (targetWorkspaceMetrics.toolboxWidth) {
       if (this.toolboxPosition_ == Blockly.TOOLBOX_AT_LEFT) {