Merge pull request #85 from kickstarter/69-spec-failures

Add 1 second buffer to expiry to correct throttles
rack · Sep 9, 2014 · 8d3e824 · 8d3e824
2 parents ba52e2c + 074e8e5
commit 8d3e824
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/rack/attack/cache.rb b/lib/rack/attack/cache.rb
@@ -16,7 +16,8 @@ def store=(store)
 
       def count(unprefixed_key, period)
         epoch_time = Time.now.to_i
-        expires_in = period - (epoch_time % period)
+        # Add 1 to expires_in to avoid timing error: http://git.io/i1PHXA
+        expires_in = period - (epoch_time % period) + 1
         key = "#{prefix}:#{(epoch_time/period).to_i}:#{unprefixed_key}"
         do_count(key, expires_in)
       end