Adds support for Redis::DistributedStore #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mezis, Thank you for you pull request. I don't think we'll add this to rack-attack in the short term. Hopefully, once #380 gets implemented, you will be able to turn this into an adapter for you and others to use it without needing to push it upstream. That's the idea going forward, to let users define new integrations (adapters) easily, without friction, instead of continue adding extra store integrations here and becoming a bottleneck. Sorry for the delay in the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis::Distributeddoesn't support pipelining the increment and the resetting of the TTL.This replaces it with a Lua script (which is supported when sharding).