Close tempfile after upload #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a big project I've been working on we've had an issue where the test suite handles a lot of file uploads. And as the total number of uploads goes over 250 we would start getting core Ruby failures from reading files. It couldn't even load normal .rb files anymore. We fixed our test suite by making sure that tempfile closes the file it was working on after it has been copied.
|
Fixed in #180, closing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a big project I've been working on we've had an issue where the test
suite handles a lot of file uploads. And as the total number of uploads
goes over 250 we would start getting core Ruby failures from reading
files. It couldn't even load normal .rb files anymore.
We fixed our test suite by making sure that tempfile closes the file it
was working on after it has been copied.