Remove some duplication #78
Conversation
|
I'm sorry, I think it's better to fix duplication without meta programming (see #111). This causes the methods to not be documented anymore and standard definitions are easier to grep for and parse for IDEs. |
|
Yup, it's a trade-off. I don't use an IDE when coding Ruby, so I have a bias towards shorter code. |
|
@nusco thank you for your pull-request. sorry for late response.
How to fix the duplication. I am considering. There are 3 PRs for that, as far as I know. |
|
@junaruga, no problem, and thanks for checking this! I didn't even remember this PR, and I guess most of it is obsolete by now. Just take what you need and leave the rest. 😃 |
This PR implements PRs #65, #74 and #78. Some of the PRs contain similar content and other are no longer based on the current readme. THis is an attempt to clean up the readme state. In addition some suggestions for further updates are part of the PR to raise the discussion about: List of maintainers and the format (email or github username) and the copyright text we want to have (or not have).
|
@junaruga Will you finish this one? If you do, please submit another PR and close this one. Leaving open for now to give room for some discussion. |
|
Closing for lack of feedback. We can reopen if the OP reappears. |
Just refactorings, and added a .travis.yml file. Warning: this pull breaks compatibility with Ruby 1.8. You may want to refuse it or pull to a branch if you care about that. Rails will drop 1.8 in the next minor release, so the time to pull the plug on 1.8 might have come.