Automated Resyntax fixes #787
Open
+114
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Using `cond` allows converting `let` to internal definitions, reducing nesting
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `else`-`if` branch of this `cond` expression can be collapsed into the `cond` expression.
This named `let` expression is equivalent to a `for` loop that uses `in-range`.
This use of `printf` has no arguments other than the template string.
These nested `for` loops can be replaced by a single `for*` loop.
These list element variable definitions can be expressed more succinctly with `match-define`. Note that the suggested replacement raises an error if the list contains more elements than expected.
This named `let` expression can be replaced by a simpler, equivalent `for/first` loop.
This quasiquotation is equialent to a simple `list` call.
This named `let` expression is equivalent to a `for` loop that uses `in-range`.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 17 issues in 10 files.
let-to-defineprintf-to-displaynamed-let-loop-to-for-in-rangelist-element-definitions-to-match-definenamed-let-loop-to-for/first-in-naturalsquasiquote-to-listnested-for-to-for*cond-else-if-to-condand-let-to-condif-let-to-condcond-let-to-cond-define