In stepper, respect the number-display format of the language.

[mikesperber]

To that end, call the underlying pretty-print-print-handler instead of format, and transform write-special'ed number markup into the corresponding snip.

[mikesperber]

I should not that the snips don't look very good, but this needs to be fixed in the framework.

[rfindler]

Is there a place to add a test case for this one? Robby

…

On Tue, Apr 29, 2025 at 6:35 AM Mike Sperber ***@***.***> wrote: *mikesperber* left a comment (racket/htdp#246) <#246 (comment)> I should not that the snips don't look very good, but this needs to be fixed in the framework. — Reply to this email directly, view it on GitHub <#246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBNMGS62M26AGQLEY4UFL235PZXAVCNFSM6AAAAAB4CUJYP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZYGMZDIMJXGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mikesperber]

Is there a place to add a test case for this one? Robby

A meaningful test for this would have to look at the actual live UI of the stepper - I haven't seen that yet. (Or am I wrong, @jbclements ?)

[jbclements]

@mike no, there's no way to look at the live GUI output that I know of, though I can add a manual checklist item to manual-tests. You probably have an easy example that I can test?

Broadly speaking: this definitely seems like an improvement.

[jbclements]

It certainly seems like the existing code ignored the existing pretty-print-size-hook, and I can't see why that would be a good thing. The direct use of format with ~s definitely seems less likely to be correct.

[mikesperber]

@rfindler Any chance you could help with making the number snips use the same font size as the stepper-sub-text%. I've tried doing set-style on the same style as in the stepper-text%'s snip, to no avail.

[rfindler]

In addition to the font size, the number snips don't follow the settings in the language dialog for the language-dialog version of BSL. When I change the setting to "Mixed fractions" in the language dialog customization of BSL, I still see repeating-decimals printing in the stepper. (It might depend on my preferences, tho, so you might need to use "Repeating decimals" to get the bad behavior.)

[rfindler]

Also, when I am trying things out, sometimes I see "placeholder26196" in the stepper where the fraction is supposed to go. I'm not sure how to make this happen but maybe it has to do with whether or not the language-based BSL is chosen when DrRacket starts up?

[mikesperber]

@rfindler For me, the stepper respects the preferences. (And the code for that is unchanged.)
With the placeholder thing you're seeing - the patch only fiddles with number markup, AFAICS. Do you have a reproducible recipe?

Also, do you have any advice on how to fix font size?