Update judgment-forms caches to use alpha-equivalence. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an immutable alpha hash constructor and update hashes in the gui to use the form provided by binding-forms.rkt Fixes racket#96
|
Regarding the performance issues I was discussing in #102, this test causes serious slow down. On my machine, it runs in 7s without that test, and ~10 minutes with. It looks like it causes lots of redundant well-formedness checks, all of which should be in the cache, but my tests lead me to believe they don't trigger the cache due to alpha equivalence. However, this PR doesn't solve the performance issues; it makes it worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #102 and should be merged after that PR. Unfortunately, this change destroys performance. I'm assuming I've done something wrong.