Automated Resyntax fixes #1452
Merged
Automated Resyntax fixes #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This `match` expression can be simplified using `match-define`.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
The `null?` predicate can be used to test for the empty list.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `define` form supports a shorthand for defining functions.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `let-values` expression can be replaced with a simpler, equivalent `call-with-values` expression.
This negated `when` expression can be replaced by an `unless` expression.
The `syntax-disarm` function is a legacy function that does nothing.
This `if` expression can be refactored to an equivalent expression using `and`.
This `map` operation can be replaced with a `for/list` loop.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
The `append-map` function can be used to map each element into multiple elements in a single pass.
The `else`-`if` branch of this `cond` expression can be collapsed into the `cond` expression.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This quasiquotation is equialent to a simple `list` call.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 20 files.
single-clause-match-to-match-definelet-to-definedefine-lambda-to-definecond-let-to-cond-definelet-values-then-call-to-call-with-valuesmap-to-forsyntax-disarm-migrationcond-else-if-to-condif-else-false-to-andquasiquote-to-listdefine-simple-macro-to-define-syntax-parse-rulefor/fold-result-keywordequal-null-list-to-null-predicateappend*-and-map-to-append-mapalways-throwing-if-to-wheninverted-when