UI combobox #48
Merged
UI combobox #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
requested changes
Jan 4, 2024
rezib
force-pushed
the
ui-combobox
branch
2 times, most recently
from
9d4c0f1 to
1331201
Compare
rezib
approved these changes
Jan 10, 2024
rezib
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Currently, the combobox does not have the focus when datacenters or infrastructures views are open:
Users have to click on the input field to get focus and start typing or selection with arrows. It would be nice to directly have the focus on the combobox to avoid this additional click.
florianLSP
force-pushed
the
ui-combobox
branch
from
46c5d1c to
f827059
Compare
rezib
requested changes
Feb 8, 2024
florianLSP
force-pushed
the
ui-combobox
branch
from
8f9cfb9 to
5f2e491
Compare
rezib
requested changes
Feb 14, 2024
Introduce custom ComboxBox component, based on Headless UI Combobox, to select either a datacenter or an infrastructure among a predefined list.
Add headlessui/vue and tailwindcss/forms dependencies required for comboboxes. Also enable forms plugin in tailwind plugin.
rezib
approved these changes
Feb 22, 2024
Use ComboBox component in Datacenters and Infrastructures views. fix #38
When Combobox is loaded in Datacenters and Infrastructures views, the focus is automatically set on the input so user can directly type or select an entry with keyboard without requiring an initial click on the Combobox.
Remove button to open/close combobox as the combobox is static and cannot actually be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #38