Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef::File::FileEdit rather than Perl ? #3

Open
jujugrrr opened this issue Apr 10, 2015 · 2 comments
Open

Chef::File::FileEdit rather than Perl ? #3

jujugrrr opened this issue Apr 10, 2015 · 2 comments

Comments

@jujugrrr
Copy link
Contributor

Hi,

Would it be better to use http://www.rubydoc.info/gems/chef/Chef/Util/FileEdit to do the search in replace ? Currently we have a dependency on Perl, the Chef::File::FileEdit seems to do nice stuff like backup of the file.
@martinb3
Copy link
Contributor

You are welcome to rewrite it -- but we're copying exactly what servermill does, so I didn't want to introduce any possible difference in behavior (bugs & all).

@jujugrrr
Copy link
Contributor Author

Oky

martinb3 pushed a commit that referenced this issue Apr 28, 2017
@karcaw
Merge pull request #3 from EMSL-MSC/fix-no-email-defaults-and-test-it…
bd2ef2a 
…-with-rspec

Fix no email defaults and test it with rspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinb3 @jujugrrr