Add toggle to stickiness due to TF/AWS API issues

[dannyleesmith]

Corresponding Issue(s):

N/A

Summary of change(s):

• make new v0.12.1 stickiness block a toggled option, missing by default, to allow for current AWS/TF issues

Reason for Change(s):

BUG: due to some issues between Terraform and the AWS API there are mixed results when creating a TCP or UDP TG that sometimes requires stickiness to be set in a specific way or not at all.

References:

hashicorp/terraform-provider-aws#9093 (comment)
hashicorp/terraform-provider-aws#15295

Will the change trigger resource destruction or replacement? If yes, please provide justification:

Believe not

Does this update/change involve issues with other external modules? If so, please describe the scenario.

No

If input variables or output variables have changed or has been added, have you updated the README?

Yes

Do examples need to be updated based on changes?

No

Note to the PR requester about Closing PR's

Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.

This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

[johnctitus]

I think we might need to implement the change to the TG Map within our test deployment. Although the test "passed" it looks like the update generated that error.

[dannyleesmith]

I think we might need to implement the change to the TG Map within our test deployment. Although the test "passed" it looks like the update generated that error.

Hi @johnctitus, in that case is the logic the correct way round? My intent was to make it so you need to add the rules as the exception, not in all cases.

[johnctitus]

I think I would be fine either way, but just want to make sure our test deployment ends in a successful build. As it sits right now, the updated code is causing a plan failure (snippet below), so we should adjust it to enable a successful plan and apply.

------------------------------------------------------------------------

Error: Network Load Balancers do not support Stickiness

  on /root/branches/sticky-issues/main.tf line 135, in resource "aws_lb_target_group" "tg":
 135: resource "aws_lb_target_group" "tg" {

[dannyleesmith]

@johnctitus I think that's the tests satisfactorily resolved now, thanks

[johnctitus]

Looks much better now. 👍