This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
[rfr] Remove imageName and flavorName from Boot From Volume #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Liberty, passing imageName and flavorName causes Nova to return a 400 error reporting that those fields are not allowed to be sent.
|
@jrperritt back with another BFV issue 😄 It's pretty easy to reproduce since the acceptance test fails on Liberty without this patch. Can you do a quick review and let me know if there's a better way to do this? Not to be a pain, but I've been trying to get these Terraform fixes in for a while now and this just blocked me :/ |
|
Ah, yep. Hmm, off the top of my head, I'm not sure why I put that logic in +2 |
jrperritt
added a commit
that referenced
this pull request
Nov 2, 2015
[rfr] Remove imageName and flavorName from Boot From Volume
|
Thanks you, sir! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Liberty, passing imageName and flavorName causes Nova to return
a 400 error reporting that those fields are not allowed to be sent.