Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Improve identity v3 support #593

Closed
wants to merge 12 commits into from

Conversation

sbourlon
Copy link

@sbourlon sbourlon commented Jun 6, 2016

OpenStack identity v3 instroduced domains which I added in this PR

  • Add project domain and domain scoping
  • Add user domain
  • Add default domain in case the domain scope and the user domain are the same

Please, let me know if I am missing something or if this PR needs to be improved.

@coveralls
Copy link

coveralls commented Jun 6, 2016

Coverage Status

Coverage decreased (-0.07%) to 80.87% when pulling d9fef25 on sbourlon:improve-identity-v3-support into d47105c on rackspace:master.

@jrperritt
Copy link
Contributor

Thank you for the PR, but this repo is currently in feature-freeze mode. See #592

@sbourlon
Copy link
Author

sbourlon commented Jun 7, 2016

Thanks @jrperritt for the update. Would it still be possible to merge the PR after the feature-freeze mode is done?

@jrperritt
Copy link
Contributor

Would it still be possible to merge the PR after the feature-freeze mode is done?

In this repo, no. In gophercloud/gophercloud, yes. The public APIs are nearly identical and compatible with one another. As in, almost all code using this library can switch to using the new library with a single gofmt command replacing the import lines, and it should just work. For code that does require changes, I'd expect them to be minor ones.

@sbourlon
Copy link
Author

sbourlon commented Jun 7, 2016

Thanks. I will test the PR against the new repo and sent a new PR to gophercloud/gophercloud.

@jrperritt
Copy link
Contributor

jrperritt commented Jun 7, 2016

Before you start, please read the description of #592 in its entirety. The new repo won't accept PRs until the contributing guide is updated and the API stabilized. You can track issue #592 for updates on the migration and status of the new repo.

@jrperritt
Copy link
Contributor

Closing this. Hopefully we'll see it in the new repo

@jrperritt jrperritt closed this Jun 8, 2016
@fatmcgav
Copy link

@sbourlon / @jrperritt Any joy with making these changes against gophercloud/gophercloud?

@jtopjian
Copy link
Contributor

@sbourlon @fatmcgav While reviewing hashicorp/terraform#7041, I spent the past few evenings looking over the current gophercloud/gophercloud v3 implementation and I think everything is already in place. I even went as far as re-implementing the scoping portion of this PR and saw that the end result was the same.

While there is no direct support for OS_PROJECT_DOMAIN_*, OS_USER_DOMAIN_*, and OS_DEFAULT_DOMAIN, by using the correct combinations of User*, Domain*, and Project*, you can achieve the correct scoping.

However, I could be wrong. If so, can someone please provide an example of where scoping still needs work in the new Gophercloud repository?

@fatmcgav
Copy link

@jtopjian I'm inclined to agree, as I've been running TF using the latest code and using domain and project scoping quite happily.

Cheers
Gav

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants