Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PHP7 to build matrix. #547

Closed
wants to merge 3 commits into from
Closed

Conversation

ycombinator
Copy link
Contributor

No description provided.

@GrahamCampbell
Copy link
Contributor

"7.0" would be a better idea btw.

@ycombinator
Copy link
Contributor Author

should we also add "7" to the list of allowed failures?

@jamiehannaford I was waiting to do that until we had our first PHP7 failure and had a chance to investigate it.

@ycombinator
Copy link
Contributor Author

The build seems to hang at a particular test. Also, one of the tests fails but we can't tell which one because the build hangs. See https://travis-ci.org/rackspace/php-opencloud/jobs/52221618.

I'm going to try and spin up a PHP 7 dev environment and investigate the failing test as well as the hanging test.

UPDATE: Also, until I can investigate and fix, I will add PHP 7 to the list of builds allowed to fail, per @jamiehannaford's suggestion earlier.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.22% when pulling c9150e0 on ycombinator:php7 into e8c07d1 on rackspace:working.

@ycombinator
Copy link
Contributor Author

Marking this PR as work in progress until I can figure out why PHP 7 builds are failing and fix if possible.

@ycombinator ycombinator deleted the php7 branch March 19, 2015 00:29
@ycombinator
Copy link
Contributor Author

I tried making php-opencloud work with PHP7 but couldn't. Any changes I needed to make it work would break with PHP 5.4. As such, after consultation with @jamiehannaford, I've decided to abandon this effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants