Simplify example for listing more than 10,000 files #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old example doesn't actually work as $total is the size of the current batch, not the total number of objects in the container. Since $marker gets set to null when $count equals $total, the example never outputs anything more than one batch of 10,000.
New method simply outputs batch after batch until there are no more files (i.e. it doesn't break until after the last filename). No need to keep track of the overall count or anything like that.
I tried to update the docs too but had some trouble with Sphinx.