Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate challenge cache when a challenge is deleted. #133

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Invalidate challenge cache when a challenge is deleted. #133

merged 2 commits into from
Jul 23, 2021

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Jul 21, 2021

No description provided.

RACTFBot
RACTFBot approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@RACTFBot RACTFBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Auto-approved due to hotfix/ branch.

@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #133 (164cc6c) into master (fbbe8ec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files         107      107           
  Lines        4587     4587           
  Branches      260      260           
=======================================
  Hits         4338     4338           
  Misses        208      208           
  Partials       41       41
Impacted Files Coverage Δ
src/challenge/signals.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbe8ec...164cc6c. Read the comment docs.

jchristgit
jchristgit previously requested changes Jul 22, 2021
View reviewed changes
src/challenge/signals.py Outdated Show resolved Hide resolved
@0xAda 0xAda requested a review from jchristgit July 23, 2021 18:58
jchristgit
jchristgit approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@jchristgit jchristgit merged commit e473b8a into master Jul 23, 2021
@jchristgit jchristgit deleted the hotfix/cache-invalidation branch July 23, 2021 19:03
0xAda pushed a commit that referenced this pull request Sep 26, 2024
@jchristgit
Merge pull request #133 from ractf/hotfix/cache-invalidation
9e6fa47 
Invalidate challenge cache when a challenge is deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RACTFBot RACTFBot RACTFBot approved these changes

@jchristgit jchristgit jchristgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xAda @jchristgit @RACTFBot