Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event name sent in verify email configurable #145

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Jul 29, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #145 (981896d) into master (652071d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   94.37%   94.36%   -0.01%     
==========================================
  Files         107      107              
  Lines        4602     4600       -2     
  Branches      262      262              
==========================================
- Hits         4343     4341       -2     
  Misses        217      217              
  Partials       42       42              
Impacted Files Coverage Δ
src/authentication/serializers.py 100.00% <ø> (ø)
src/backend/settings/__init__.py 72.46% <ø> (ø)
src/challenge/serializers.py 87.03% <ø> (-0.06%) ⬇️
src/challenge/views.py 68.09% <ø> (-0.13%) ⬇️
src/challenge/signals.py 100.00% <100.00%> (ø)
src/challenge/tests/test_views.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652071d...981896d. Read the comment docs.

Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you dave.

We need to configure this in the current event, too. Where can we do that?

@0xAda 0xAda enabled auto-merge July 29, 2021 19:39
@0xAda 0xAda merged commit 3d2236f into master Jul 29, 2021
@0xAda 0xAda deleted the feature/email-templates branch July 29, 2021 20:10
0xAda added a commit that referenced this pull request Sep 26, 2024
Make event name sent in verify email configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants