Skip to content

Timestamp the logs #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2021
Merged

Timestamp the logs #158

merged 1 commit into from
Aug 6, 2021

Conversation

thebeanogamer
Copy link
Member

@thebeanogamer thebeanogamer enabled auto-merge (squash) August 6, 2021 18:32
@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #158 (ae02269) into master (083a488) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files         107      107           
  Lines        4632     4632           
  Branches      265      265           
=======================================
  Hits         4372     4372           
  Misses        218      218           
  Partials       42       42
Impacted Files Coverage Δ
src/backend/settings/__init__.py 72.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083a488...ae02269. Read the comment docs.

0xAda
0xAda approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thebeanogamer thebeanogamer merged commit 3a4752f into master Aug 6, 2021
jchristgit
jchristgit requested changes Aug 6, 2021
View reviewed changes
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests missing.

@thebeanogamer thebeanogamer deleted the feature/timestamp branch August 6, 2021 18:34
jchristgit added a commit that referenced this pull request Aug 6, 2021
@jchristgit
Revert "Timestamp the logs (#158)"
14c08a7 
This reverts commit 3a4752f.
@jchristgit jchristgit mentioned this pull request Aug 6, 2021
Closed
0xAda pushed a commit that referenced this pull request Sep 26, 2024
@thebeanogamer
Timestamp the logs (#158)
3a3ce99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit requested changes

@0xAda 0xAda 0xAda approved these changes

@jerbob jerbob jerbob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebeanogamer @0xAda @jchristgit @jerbob