Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Prometheus metrics for websockets. #172

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Expose Prometheus metrics for websockets. #172

merged 1 commit into from
Aug 10, 2021

Conversation

jchristgit
Copy link
Collaborator

No description provided.

@jchristgit jchristgit self-assigned this Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #172 (fbf75fa) into master (b525886) will not change coverage.
The diff coverage is n/a.

❗ Current head fbf75fa differs from pull request most recent head 7862bad. Consider uploading reports for the commit 7862bad to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files         107      107           
  Lines        4646     4646           
  Branches      265      265           
=======================================
  Hits         4386     4386           
  Misses        218      218           
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b525886...7862bad. Read the comment docs.

@jchristgit jchristgit force-pushed the django-prometheus-crash branch from fbf75fa to 7862bad Compare August 10, 2021 18:53
@jchristgit jchristgit requested a review from jerbob August 10, 2021 18:53
@jchristgit jchristgit removed their assignment Aug 10, 2021
@jchristgit jchristgit marked this pull request as ready for review August 10, 2021 18:54
0xAda
0xAda approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xAda 0xAda merged commit 05d1c03 into master Aug 10, 2021
@0xAda 0xAda deleted the django-prometheus-crash branch August 10, 2021 18:55
0xAda added a commit that referenced this pull request Sep 26, 2024
@0xAda
Merge pull request #172 from ractf/django-prometheus-crash
f4f64c2 
Expose Prometheus metrics for websockets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerbob jerbob jerbob approved these changes

@0xAda 0xAda 0xAda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchristgit @0xAda @jerbob