Event antiflood #28
Open
Event antiflood #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've found that this version doesn't fully solve issue, It still pretty slow in some cases. #22 worked better. I'll work on this PR. But @rstacruz, @Rich-Harris, I still want your feedback about this implementation. |
|
Ok, it was simple but painful bug. Now it works good for me and can fully replace #22 |
|
Last commit 9e8e4de doesn't relate to this PR and may be useful separately. Should protect from such bugs in future. |
|
Ok, initial idea with patched |
|
@rstacruz, @Rich-Harris, guys, what about this PR? |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronous version of #22 , implementation of #22 (comment) idea.
Decorate (and undecorate)
collection.syncmethod to intercept update and receive presyncevent (https://github.com/jashkenas/backbone/blob/1.1.2/backbone.js#L863 https://github.com/paulmillr/exoskeleton/blob/0.7.0/exoskeleton.js#L1090)Lock all update events during ajax-driven collection update and then trigger custom update event for all listening
BackboneCollectionWrappers.Old synchronous tests approve this patch.