Added component.json and changed require('ractive') to require('Ractive') #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmaranan
added a commit
to jmmaranan/ractive-events-tap
that referenced
this pull request
Sep 25, 2017
The line to declare window.PointerEvent explicitly should not be done because that should be delivered by Chrome or IE Edge. First test is failing on Chrome 56 but passes a simulation of IE Edge test ractivejs#3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured you might be able to use some of the work that I did on making Ractive-events-tap compatible with component. You'll definitely have to change the
dependenciesin component.json though.Also, RactiveJS/Ractive::component.json exports ractive as "Ractive" (i.e.with a capital R). This was causing the loading of Ractive-events-tap to fail. So I changed 'ractive' to 'Ractive'.