Add support for bubbling events #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the template to specify that an event should bubble to the first available handler up the component hierarchy (
*- bubbled) or all the way to the root (**- double bubbled). Double bubbled events get acancelBubblefunction added to them to stop the bubbling. I tried adding a cancelBubble to all events, but it failed a magic change test where the data is passed instead of an event.Since ancestor events using
../couple the publishers and subscribers, and namespaced events seem to have some other complexity issues surrounding them (how to subscribe form a template, how to change the namespace, etc) bubbling seems like the next logical attempt to cut down on event proxy boilerplate in nested component templates. It would also allow components designed to be nested to fire events up-tree by default if they so desire, and it keeps the event context available to the appropriate callbacks.See the tests for contrived examples. Is this closer to generally useful?