Expose DOM nodeRactive info in public API - RFC #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Definitely makes sense to have this as a static method, and returning a fresh object rather than |
"When JavaScript is your hammer, everything looks like a thumb." The last commit adds support for indices that exist beyond (non-isolated) component boundaries. If everything looks ok, it's ready to merge. |
Rich-Harris
added a commit
that referenced
this pull request
Nov 29, 2014
Expose DOM nodeRactive info in public API - RFC
|
LGTM. Nice one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had occasion to use this today, so here is an implementation as described in @martpdx's comment in #1217. Having
.parent,.container, and friends make this even more useful.Indices don't currently propagate through to component nodes nicely, but #1474 should take care of that.
This fixes #1217.