-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up change-yaml.sh to generate md5 sum for spark #281
Conversation
This is transitional while we wait for sha512 support in cekit.
remove this download when sha512 support lands in upstream cekit (tmckay)Lines 73 to 78 in 9deb637
This comment was generated by todo based on a
|
remove this checksum calculation when sha512 support lands in upstream cekit (tmckay)Lines 93 to 98 in 9deb637
This comment was generated by todo based on a
|
replace this with sha512 when it lands in upstream cekit (tmckay)Lines 113 to 118 in 9deb637
This comment was generated by todo based on a
|
@elmiko ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, i think my change has gone into upstream cekit for the sha512 stuff. maybe we should confirm it in our build pipeline?
is that part of cekit 3? if so we need to modify the image.yamls, we can do that all at once |
looks like my changes are in cekit 3.1 for sure, so maybe we should just proceed as is and leave the todos for later. |
Merging before tests complete, this is just a utility script |
This is transitional while we wait for sha512 support in cekit.