Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bind ^I rl_complete for macos #79

Closed
wants to merge 1 commit into from

Conversation

dnakov
Copy link
Collaborator

@dnakov dnakov commented Oct 22, 2024

Checklist

  • Closing issues: #issue
  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some documentation

Description

tab works now, can type b. (Sequoia 15.1). Reject if this breaks it on your mac.

@trufae
Copy link
Contributor

trufae commented Oct 22, 2024

In my case this makes do nothing on macOS

@dnakov
Copy link
Collaborator Author

dnakov commented Oct 23, 2024

Just tried it on another mac, tab works fine with this PR, no "b", no tab on master

$ python3 -c "import readline; print(readline.__doc__)"
Importing this module enables command line editing using GNU readline.

$ sw_vers
ProductName:		macOS
ProductVersion:		14.5
BuildVersion:		23F79

@trufae
Copy link
Contributor

trufae commented Oct 24, 2024

in my case i got this:

$ python3 -c "import readline; print(readline.__doc__)"
Importing this module enables command line editing using libedit readline.
$ sw_vers
ProductName:		macOS
ProductVersion:		15.0.1
BuildVersion:		24A348

guess its time for another if

trufae pushed a commit that referenced this pull request Oct 24, 2024
@trufae
Copy link
Contributor

trufae commented Oct 24, 2024

i think we can close this PR now, please confirm on master

@trufae trufae closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants