-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Python arch plugin #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Ill merge after fixing those little things. Encoding should be easy to implement too
python/examples/test-py-arch.py
Outdated
# | ||
# The r2lang.plugin function exposes a way to register new plugins | ||
# into the RCore instance. This API is only available from RLang. | ||
# You must call with with '#!python test.py' or 'r2 -i test.py ..' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better use -I to load earlier
the resr of comments can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied that from the other examples. Would be nice if -a would run after the plugin is loaded, but no difference between -i and -I for that.
Checklist
Description
Adding support for arch plugins to the Python plugin interface.
So far only implements decode (disassembling).