Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement callback for init in Python arch plugin #45

Merged
merged 1 commit into from
May 6, 2024
Merged

Implement callback for init in Python arch plugin #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/examples/test-py-arch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
from r2lang import R

def pyarch(a):
# called when arch is activated in radare2, useful to run r2 commands
# with rlang.cmd() to set variables or create IO maps
def init():
r2lang.cmd("e asm.syntax=intel")
return

# describes layout of register file for the architecture
# return: string with layout of the register file
def regs():
Expand Down Expand Up @@ -139,6 +145,7 @@ def encode(addr, str):
"bits": 32,
"license": "GPL",
"desc": "arch plugin in python",
"init": init,
"regs": regs,
"info": info,
"decode": decode,
Expand Down
50 changes: 31 additions & 19 deletions python/python/arch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,20 +192,32 @@ void py_export_arch_enum(PyObject *tp_dict) {
}

static bool py_arch_init(RArchSession *as) {
// is this needed/called?
// R_LOG_INFO ("py_arch_init called");
r_return_val_if_fail (as, false);
// R_LOG_WARN ("py_arch_init not implemented");
return true;
int res = true; // it's ok if init is missing
if (py_arch_init_cb) {
PyObject *result = PyObject_CallObject (py_arch_init_cb, NULL);
if (result) {
// no return value expected
Py_DECREF (result);
}
if (PyErr_Occurred ()) {
PyErr_Print ();
res = false;
}
}
return res;
}

static bool py_arch_fini(RArchSession *as) {
// is this needed/called?
R_LOG_WARN ("py_arch_fini not implemented");
r_return_val_if_fail (as, false);
// R_LOG_WARN ("py_arch_fini not implemented");
return true;
}

static int py_arch_info(RArchSession *as, ut32 q) {
// R_LOG_INFO ("py_arch_info called");
r_return_val_if_fail (as, -1);
int res = -1;
if (py_arch_info_cb) {
Expand All @@ -216,17 +228,18 @@ static int py_arch_info(RArchSession *as, ut32 q) {
res = PyLong_AsLong (result);
}
Py_DECREF (result);
} else {
PyErr_Print();
}
Py_DECREF (arglist);
if (PyErr_Occurred ()) {
PyErr_Print ();
}
}
return res;
}

static char *py_arch_regs(RArchSession *as) {
r_return_val_if_fail (as, NULL);
// R_LOG_INFO ("py_arch_regs called");
r_return_val_if_fail (as, NULL);
char *res = NULL;
if (py_arch_regs_cb) {
PyObject *result = PyObject_CallObject (py_arch_regs_cb, NULL);
Expand All @@ -238,16 +251,17 @@ static char *py_arch_regs(RArchSession *as) {
}
}
Py_DECREF (result);
} else {
PyErr_Print();
}
if (PyErr_Occurred ()) {
PyErr_Print ();
}
}
return res;
}

static bool py_arch_encode(RArchSession *as, RAnalOp *op, RArchEncodeMask mask) {
r_return_val_if_fail (as && op, false);
// R_LOG_INFO ("py_arch_encode called");
r_return_val_if_fail (as && op, false);
bool res = false;
if (py_arch_encode_cb) {
PyObject *arglist = Py_BuildValue ("(Ks)", op->addr, op->mnemonic);
Expand All @@ -267,19 +281,18 @@ static bool py_arch_encode(RArchSession *as, RAnalOp *op, RArchEncodeMask mask)
Py_DECREF (result);
}
Py_DECREF (arglist);
if (PyErr_Occurred ()) {
PyErr_Print ();
}
} else {
R_LOG_WARN ("Python arch plugin does not implement encode");
}
if (PyErr_Occurred ()) {
PyErr_Print ();
}
return res;
}

static bool py_arch_decode(RArchSession *as, RAnalOp *op, RAnalOpMask mask) {
r_return_val_if_fail (as && op, false);
// WIP
// R_LOG_INFO ("py_arch_decode called");
r_return_val_if_fail (as && op, false);
bool res = false;
if (py_arch_decode_cb) {
Py_buffer pybuf = {
Expand Down Expand Up @@ -384,13 +397,12 @@ static bool py_arch_decode(RArchSession *as, RAnalOp *op, RAnalOpMask mask) {
}
Py_DECREF (arglist);
Py_DECREF (memview);
if (PyErr_Occurred ()) {
PyErr_Print ();
}
} else {
R_LOG_WARN ("Python arch plugin does not implement decode");
}

if (PyErr_Occurred ()) {
PyErr_Print ();
}
return res;
}

Expand Down
Loading