Fix null deref when no signature is found ##bin

radareorg · Feb 2, 2023 · 586af3f · 586af3f
1 parent 4808a2a
commit 586af3f
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/libr/core/cbin.c b/libr/core/cbin.c
@@ -4319,16 +4319,18 @@ static bool bin_signature(RCore *r, PJ *pj, int mode) {
 	RBinFile *cur = r_bin_cur (r->bin);
 	RBinPlugin *plg = r_bin_file_cur_plugin (cur);
 	if (plg && plg->signature) {
-		const char *signature = plg->signature (cur, IS_MODE_JSON (mode));
-		if (IS_MODE_JSON (mode)) {
-			pj_o (pj);
-			pj_k (pj, "signature");
-			pj_j (pj, signature);
-			pj_end (pj);
-		} else {
-			r_cons_println (signature);
+		char *signature = plg->signature (cur, IS_MODE_JSON (mode));
+		if (signature) {
+			if (IS_MODE_JSON (mode)) {
+				pj_o (pj);
+				pj_k (pj, "signature");
+				pj_j (pj, signature);
+				pj_end (pj);
+			} else {
+				r_cons_println (signature);
+			}
+			free (signature);
 		}
-		free ((char*) signature);
 		return true;
 	}
 	if (IS_MODE_JSON (mode)) {