Fix #15235 - push [mem] not handled in /r ##anal

radareorg · Oct 10, 2019 · d2d95f6 · d2d95f6
1 parent 32dafd2
commit d2d95f6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/libr/anal/p/anal_x86_cs.c b/libr/anal/p/anal_x86_cs.c
@@ -2458,6 +2458,15 @@ static void anop(RAnal *a, RAnalOp *op, ut64 addr, const ut8 *buf, int len, csh
 	case X86_INS_PUSHFD:
 	case X86_INS_PUSHFQ:
 		switch (INSOP(0).type) {
+		case X86_OP_MEM:
+			if (INSOP(0).mem.disp) {
+				op->val = op->ptr = INSOP(0).mem.disp;
+				op->type = R_ANAL_OP_TYPE_PUSH;
+			} else {
+				op->type = R_ANAL_OP_TYPE_UPUSH;
+			}
+			op->cycles = CYCLE_REG + CYCLE_MEM;
+			break;
 		case X86_OP_IMM:
 			op->val = op->ptr = INSOP(0).imm;
 			op->type = R_ANAL_OP_TYPE_PUSH;

diff --git a/libr/asm/arch/8051/8051_ass.c b/libr/asm/arch/8051/8051_ass.c
@@ -347,17 +347,15 @@ static bool address_bit(char const* addr_str, ut8* addr_out) {
 	char const *separator = r_str_lchr (addr_str, '.');
 	ut8 byte;
 	int bit;
-	bool ret;
+	bool ret = false;
 	if (!separator) {
 		// FIXME: accept symbols as well as dot-notation
-		ret = false;
 		goto end;
 	}
 	r_str_ncpy (bytepart, addr_str, separator - addr_str + 1);
 	bytepart[separator - addr_str + 1] = '\0';
 	r_str_ncpy (bitpart, separator + 1, strlen(separator));
 	if (!address_direct (bytepart, &byte)) {
-		ret = false;
 		goto end;
 	}
 	if (1 < strlen (bitpart)