Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14845: Support radare2_rc in radiff2 for graphs #15078

Merged
merged 4 commits into from
Sep 20, 2019

Conversation

deepakchethan
Copy link
Contributor

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Sep 19, 2019

This pull request fixes 1 alert when merging 0c8401c into fd1e3ba - view on LGTM.com

fixed alerts:

  • 1 for Local variable hides global variable

libr/core/cconfig.c Outdated Show resolved Hide resolved
libr/core/cconfig.c Outdated Show resolved Hide resolved
libr/core/cconfig.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@radare radare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2019

This pull request introduces 1 alert and fixes 1 when merging 5a68afa into 0b9edb4 - view on LGTM.com

new alerts:

  • 1 for Local variable hides global variable

fixed alerts:

  • 1 for Local variable hides global variable

libr/util/sys.c Outdated
R_API bool r_sys_getenv_asbool(const char *key) {
char *env = r_sys_getenv (key);
if (env) {
if (*env || *env=='1') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use free instead of r_free and add spaces around ==

@radare radare merged commit 5cf107e into radareorg:master Sep 20, 2019
@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2019

This pull request introduces 1 alert and fixes 1 when merging 72cba0e into 9f63bec - view on LGTM.com

new alerts:

  • 1 for Local variable hides global variable

fixed alerts:

  • 1 for Local variable hides global variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants