Integrate table API for p-h

[deepakchethan]

Table API Now supports UTF8, UTF8 curvy, aggregating footer:

[radare]

This last row of "total" should be part of the RTable API instead of manually crafted everytime, can you add an api in rtable to sum all the rows and show that at the end with a separator? the only XX test is the one that expects the old output, and i think it will be good to have this before merging it.

thanks!

[radare]

.

[radare]

.

[radare]

look at the new apis i added about rtrable ;)

[radare]

You have to create a function in core that creates a table with the selected settings. This function must be in core not in util

…

On 23 Sep 2019, at 08:48, dodococo ***@***.***> wrote:  @deepakchethan commented on this pull request. In libr/util/table.c: > @@ -70,6 +71,8 @@ R_API RTable *r_table_new() { t->showHeader = true; t->cols = r_list_newf (r_table_column_free); t->rows = r_list_newf (r_table_row_free); + t->useUtf8 = true; I cannot bring in the RCons directly here. It is giving me an error. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

[deepakchethan]

@radare, I have integrated the star= based commands with table API and moved the r_core_visual_list into table.c as well.

[lgtm-com]

This pull request fixes 1 alert when merging e5adfabcefadb160d7786756cfe96f39ba99d510 into b263363 - view on LGTM.com

fixed alerts:

• 1 for Local variable hides global variable

[lgtm-com]

This pull request fixes 1 alert when merging 1c761b7 into b263363 - view on LGTM.com

fixed alerts:

• 1 for Local variable hides global variable