Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15296 - *BSD builds #15309

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fix #15296 - *BSD builds #15309

merged 1 commit into from
Oct 18, 2019

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Oct 18, 2019

No description provided.

Copy link
Contributor

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit ugly IMHO. It would be better to just extract a function is_pid_already_attached and just make that function always return false on systems that are not linux.

libr/io/p/io_ptrace.c Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2019

This pull request introduces 1 alert when merging 6bfa186488aa50550c40c33ad541d573b91c5a0f into d9fa409 - view on LGTM.com

new alerts:

  • 1 for Missing return statement

@XVilka
Copy link
Contributor Author

XVilka commented Oct 18, 2019

For some reason it breaks the Linux debugger

@ret2libc
Copy link
Contributor

It does not break Linux debugger. Master is already red for this. I think the test is wrong and I have submitted a pr to r2r

@radare radare merged commit 0f430b5 into radareorg:master Oct 18, 2019
thestr4ng3r added a commit that referenced this pull request Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants