Implement refinements for acyclic regions #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this just sticks the new nodes at the end, which almost certainly will break the topological ordering of the region.
HMPerson1
force-pushed
the
cfs_refinements
branch
from
7adba7b to
d27f6f7
Compare
HMPerson1
force-pushed
the
cfs_refinements
branch
from
1c175d3 to
0ce108d
Compare
|
@sushant94 @chinmaydd @kriw please review |
|
I think @HMPerson1 is yet to complete 2 TODOs (or he can split them into another PR). |
Each condition now also stores its own negation so we can easily find the negation of an expression inside a different expression and simplify based on that.
HMPerson1
force-pushed
the
cfs_refinements
branch
from
c34add7 to
2d96736
Compare
HMPerson1
changed the title
|
@sushant94 This can be merged. |
|
@kriw would you like to take a look at this PR and help review it? |
kriw
requested changes
Jul 14, 2018
| @@ -0,0 +1,32 @@ | |||
| #[derive(Debug, Eq, PartialEq)] | |||
| pub enum AstNode<B, C, V> { | |||
There was a problem hiding this comment.
I would like you to leave comments what each B, C, V represents.
| Cond(c, t, oe) => { | ||
| let ot = simplify_ast_node::<A>(cctx, *t); | ||
| let oe = oe.and_then(|e| simplify_ast_node::<A>(cctx, *e)); | ||
| if c.is_true() { |
There was a problem hiding this comment.
match (c, t, oe) {
(c, _, _) if c.is_true() => ot,
(c, _, _) if c.is_false() => oe,
(c, Some(t), _) => Some(...),
(c, _, Some(e), _) => Some(...),
_ => None
}
would shorten the code.
There was a problem hiding this comment.
The c.is_true/false can't be in a match because by-move patterns can't have pattern guards, but the last part is indeed cleaner. Thanks!
|
LGTM :) |
|
Merging. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if-then-elseif-thensCondition-aware refinementsPostponed until Fold conditional flags into original ones #171 is done