Skip to content

Commit

Permalink
default log level to NONE for live project (#399)
Browse files Browse the repository at this point in the history
* remove check for canFlushLogs
  • Loading branch information
ShiCheng-Lu authored Oct 4, 2024
1 parent 801044b commit 6d25648
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
12 changes: 0 additions & 12 deletions RadarSDK/Radar.m
Original file line number Diff line number Diff line change
Expand Up @@ -1351,23 +1351,11 @@ - (void)dealloc {
[[NSNotificationCenter defaultCenter] removeObserver:self];
}

+ (BOOL)canFlushLogs {
NSString *publishableKey = [RadarSettings publishableKey];
if ([publishableKey hasPrefix:@"prj_test_pk"] || [publishableKey hasPrefix:@"org_test_pk"] || [RadarSettings userDebug] || ([RadarSettings sdkConfiguration].logLevel && [RadarSettings sdkConfiguration].logLevel != RadarLogLevelNone)) {
return YES;
}
return NO;
}

+ (void)sendLog:(RadarLogLevel)level type:(RadarLogType)type message:(NSString *_Nonnull)message {
[[RadarLogBuffer sharedInstance] write:level type:type message:message ];
}

+ (void)flushLogs {
if (![self canFlushLogs]) {
return;
}

NSArray<RadarLog *> *flushableLogs = [[RadarLogBuffer sharedInstance] flushableLogs];
NSUInteger pendingLogCount = [flushableLogs count];
if (pendingLogCount == 0) {
Expand Down
4 changes: 2 additions & 2 deletions RadarSDK/RadarSettings.m
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ + (void)setSdkConfiguration:(RadarSdkConfiguration *)sdkConfiguration {
[RadarUtils dictionaryToJson:[sdkConfiguration dictionaryValue]]]];
if (sdkConfiguration) {
[[RadarLogBuffer sharedInstance] setPersistentLogFeatureFlag:sdkConfiguration.useLogPersistence];
[[NSUserDefaults standardUserDefaults] setInteger:(int)sdkConfiguration.logLevel forKey:kLogLevel];
[RadarSettings setLogLevel:sdkConfiguration.logLevel];
[[NSUserDefaults standardUserDefaults] setObject:[sdkConfiguration dictionaryValue] forKey:kSdkConfiguration];
} else {
[[RadarLogBuffer sharedInstance] setPersistentLogFeatureFlag:NO];
Expand All @@ -263,7 +263,7 @@ + (RadarLogLevel)logLevel {
}

+ (void)setLogLevel:(RadarLogLevel)level {

[[NSUserDefaults standardUserDefaults] setInteger:(int)level forKey:kLogLevel];
}

+ (NSArray<NSString *> *_Nullable)beaconUUIDs {
Expand Down

0 comments on commit 6d25648

Please sign in to comment.