add event notification prefix #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeier
approved these changes
Jan 11, 2024
ShiCheng-Lu
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Bump play services location * Bump version to 3.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification identifier is currently just the
eventId. This can lead to developer error as consumers of the SDK may also be listening toradarEventsto generate notifications. In particular, it may seem intuitive to the developer to use theeventIdas the identifier of the notification. However, we are also doing the same thing. Registering 2 notifications with the same identifier at the same time will the cause the first notification to be dropped silently.This PR fixes this issue by prefixing the identifier with another string to avoid such conflicts.
QA: successfully generate notifications with waypoint.
