Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for flakey GH tests #334

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Increase timeout for flakey GH tests #334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b057628
comment out new tests
KennyHuRadar Apr 30, 2024
059cf80
uncomment tests and increase timeout
KennyHuRadar Apr 30, 2024
7fcaa50
uncomment tests
KennyHuRadar Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RadarSDKTests/RadarSDKTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ - (void)test_Radar_getContext_errorLocation {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:60
[self waitForExpectationsWithTimeout:120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the explanation for why we weren't seeing this before? Or were we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were, they come sporadically after we upgraded the github action to simulate an iphone 15 pro

handler:^(NSError *_Nullable error) {
if (error) {
XCTFail();
Expand Down
Loading