automate lifecycle logging #361
Conversation
RadarSDK/Radar.m
Outdated
|
|
||
| [[NSNotificationCenter defaultCenter] addObserver:[self sharedInstance] | ||
| selector:@selector(logTermination) | ||
| name:UIApplicationWillTerminateNotification | ||
| object:nil]; | ||
| [[NSNotificationCenter defaultCenter] addObserver:[self sharedInstance] | ||
| selector:@selector(logBackgrounding) | ||
| name:UIApplicationDidEnterBackgroundNotification | ||
| object:nil]; | ||
| [[NSNotificationCenter defaultCenter] addObserver:[self sharedInstance] | ||
| selector:@selector(logResigningActive) | ||
| name:UIApplicationWillResignActiveNotification | ||
| object:nil]; |
There was a problem hiding this comment.
Let's add some sdk config flag here to gate this.
There was a problem hiding this comment.
Plan will be to ship this alongside or immediately after #357
There was a problem hiding this comment.
I can add the server code and help with the sdk flag, we should add the flag to android as well. (android right now automatically logs lifecycle)
There was a problem hiding this comment.
I actually think its ok to merge this and add sdk flag later as well, since in android right now it logs lifecycle it by default.
There was a problem hiding this comment.
If we go that route, we'll need to call out that people need to remove their manual impl of these methods.
There was a problem hiding this comment.
this PR actually removes those functions, so it'll be a "breaking change", so we should either keep the functions (make them no-op, and add this lifecycle callback by default so people who didn't set it up get it as a new feature, and people who did set it up are not broken and still get the logs) or pack it with 4.0.0
lmeier
force-pushed
the
automate-lifecycle-logging
branch
from
2efe6e4
to
63e7687
Compare
|
Trying to understand why tests are failing here |
The deprecation annotation angered the linter.... The github action CI test failing is probably due to its lack of speed at the end of the day. The same failing test passed in circle CI so I would disregard them. |
Automate lifecycle logging and remove the need for users to mess with the app delegate.
This should be shipped as part of one line. It should be configured by either/both client side arguments.