-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event metadata for campaigns #433
base: master
Are you sure you want to change the base?
Conversation
NSString *notificationURL = [metadata objectForKey:@"radar:notificationURL"]; | ||
NSString *campaignId = [metadata objectForKey:@"radar:campaignId"]; | ||
|
||
if (notificationText) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (notificationText) { | |
if (notificationText & campaignType = 'notification') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I right to say that this check is just for consistency?
Or do we see a future where we are explicitly using nearby geofences synced down for in app messaging as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this in-person — idea is to be able to use the other metadata keys for different campaign types (notificaitons, in-app messages, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression was that that differentiation is only to be made for metadata on events, and implemented the checks within the logic extracting that info from the event based notifications.
Are you suggesting this change as we are intending to also leverage nearby geofences for in app messaging , hence necessitating this be done for both client side geofences and event based campaigns?
No description provided.