Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure build-scan plugin #112

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Configure build-scan plugin #112

merged 1 commit into from
Mar 13, 2019

Conversation

aalmiray
Copy link
Contributor

@aalmiray aalmiray commented Mar 4, 2019

This small PR configures the build-scan Gradle plugin (https://guides.gradle.org/creating-build-scans/) which yields further insight into the build, allowing the team to make informed decisions on where and when the build may be tweaked to get faster, more performant builds.

@radarsh
Copy link
Owner

radarsh commented Mar 4, 2019

Is this a duplicate of the other very similar PR?

@aalmiray
Copy link
Contributor Author

aalmiray commented Mar 4, 2019

Indeed it is. I'm so sorry for the dup, for some reason my working copy did not have the changes I submitted before. Closing.

@aalmiray aalmiray closed this Mar 4, 2019
@radarsh
Copy link
Owner

radarsh commented Mar 5, 2019

Did you mean to keep this PR open and close the other one (#110?)

@aalmiray
Copy link
Contributor Author

aalmiray commented Mar 5, 2019

I closed this PR because it was more recent but it looks like #110 brings more commits than it should.

@aalmiray aalmiray reopened this Mar 5, 2019
@radarsh radarsh merged commit 7c4c084 into radarsh:develop Mar 13, 2019
@aalmiray
Copy link
Contributor Author

Thanks! 😄

@aalmiray aalmiray deleted the gradle-build-scan branch March 13, 2019 17:02
@radarsh
Copy link
Owner

radarsh commented Mar 13, 2019

No, thank you 👍. I have to remember to use 2.2.x version of the build-scan plugin when I upgrade to Gradle 5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants