Configuration option for changing the log level #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @rabidaudio, thanks for submitting this PR. I will review this in the near future and provide feedback. |
|
looks good to me-- has this been tested in kotlin-dsl? |
radarsh
requested changes
Oct 7, 2019
src/test/groovy/com/adarshr/gradle/testlogger/logger/ConsoleLoggerSpec.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/com/adarshr/gradle/testlogger/TestLoggerExtension.groovy
Show resolved
Hide resolved
|
Sorry for the delay here. I addressed the issues and rebased against develop. |
radarsh
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration option
logLevelwhich can be one of the Gradle log levels.I realize it's a bit strange to log test results on any level other than
lifecyclebut the use case we're experiencing is that Gradle is printing a lot of noise for various compilation tasks (an Android project with multiple modules) and the test results get lost in the noise, so we are going to pass--quietand have our test results log onquiet. Totally understand if you don't want to support this use case, we can keep using our fork.I added a unit test and functional test, but I forgot to update the docs. If you're interested in accepting this PR let me know and I'll update the docs.