feat(throttle): add trailing option
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishoj
changed the title
falling option for throttlefalling option for throttle
crishoj
changed the title
falling option for throttletrailing option for throttle
|
Corrected a few defects:
|
aleclarson
added
the
new feature
aleclarson
force-pushed
the
falling-option-for-throttle
branch
from
d4ba2f2 to
3be2da6
Compare
…ailing call, expand test
- Tweak some variable names - Make the “call time” variable always a number, so the undefined check can be removed - Inline all references to current time
aleclarson
force-pushed
the
falling-option-for-throttle
branch
from
3be2da6 to
251bffc
Compare
crishoj
commented
Jul 23, 2024
| when invoked. When the returned function is invoked it will only call the source | ||
| function if the `interval` milliseconds of time has passed. Otherwise, it will ignore | ||
| the invocation. | ||
| The `throttle` function creates a new function that, when called, will only execute the original function at most once per specified time interval. This is useful for limiting the rate at which a function can fire, especially for performance-intensive operations like handling scroll or resize events. |
aleclarson
changed the title
trailing option for throttletrailing option
|
Merging this with a failed test, which will be fixed in another PR. |
Thanks for the cleanup and refactoring! |
|
Thanks for contributing @crishoj. 👍 👍 Please keep up the great work :) I'll get to your other PR soon, but have some stuff to finish for the documentation site. |
|
A new beta version To install: pnpm add radashi@12.2.0-beta.83909afThe 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
This adds a
trailingoption forthrottle, which results in the source function being invoked again afterintervalin case any calls were ignored during the throttled period.This is useful for situations where an observable is frequently changing, and we wish to throttle an observer without missing any updates.
Related issue, if any:
sodiray/radash#387
For any code change,
Does this PR introduce a breaking change?
No