Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): let zipToObject receive readonly arrays #294

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix(types): let zipToObject receive readonly arrays #294

merged 3 commits into from
Nov 7, 2024

Conversation

aeharding
Copy link
Contributor

@aeharding aeharding commented Nov 7, 2024 •
edited by radashi-bot
Loading

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Summary

The zipToObject function did not work with readonly/const arrays

Related issue, if any:

#288

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed
  • Related benchmarks have been added or updated, if needed

Does this PR introduce a breaking change?

No

@aeharding aeharding requested a review from aleclarson as a code owner November 7, 2024 06:36
MarlonPassos-git
MarlonPassos-git suggested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@MarlonPassos-git MarlonPassos-git left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, only one point:

Since the original error is related to types, I think it's interesting to include the other variants to ensure that everything is working.

@aleclarson aleclarson changed the title fix(zipToObject): accepts readonly array types fix(types): let zipToObject receive readonly arrays Nov 7, 2024
@aleclarson aleclarson merged commit 2c68597 into radashi-org:main Nov 7, 2024
8 checks passed
@aleclarson
Copy link
Member

I've added the type tests from Marlon and added him as co-author. 👍

Thanks to you both! ❤️

@aeharding aeharding deleted the zipToObject branch November 8, 2024 04:49
@radashi-bot
Copy link

A stable release 12.2.1 has been published to NPM. 🚀

To install:

pnpm add radashi@12.2.1
See the changes

MarlonPassos-git added a commit to MarlonPassos-git/radashi that referenced this pull request Nov 10, 2024
@aeharding @aleclarson @MarlonPassos-git
fix(types): let zipToObject receive readonly arrays (radashi-org#294)
cae1c56 
Co-authored-by: Alec Larson <1925840+aleclarson@users.noreply.github.com>
Co-authored-by: Marlon Passos <marlon.passos@cadastra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonPassos-git MarlonPassos-git MarlonPassos-git requested changes

@aleclarson aleclarson Awaiting requested review from aleclarson aleclarson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aeharding @aleclarson @radashi-bot @MarlonPassos-git